search

Azure / Enterprise-Scale

The Azure Landing Zones (Enterprise-Scale) architecture provides prescriptive guidance coupled with Azure best practices, and it follows design principles across the critical design areas for organizations to define their Azure architecture
https://aka.ms/alz
MIT License
1.7k stars 964 forks source link

Feature Request - add policy replacement id in description for deprecated #1368

Closed vegazbabz closed 1 year ago

vegazbabz commented 1 year ago

It would be great if you in the description of a policy def, could add the policy id of the new policy that is replacing a deprecated policy, so that you do not have to manually sit and connect the dots.

jtracey93 commented 1 year ago

Hey @vegazbabz,

We should be doing this already in our latest policy refreshes.

Please provide a list of any you have spotted and we will address going forward.

cc: @Springstone @paulgrimley

vegazbabz commented 1 year ago

Multiple, unfortunately. I have also seen the opposite, so it is not consistant.

Couldn't find more than these:

This two have it:

paulgrimley commented 1 year ago

@vegazbabz thanks for awareness, we do document these here https://github.com/Azure/Enterprise-Scale/wiki/ALZ-Deprecated-Services#deprecated-policies but as you suggest having them within the description also helps. Will work on getting these updated.

paulgrimley commented 1 year ago

Backlog item created AB#29467

Springstone commented 1 year ago

I was just going to share the same @paulgrimley. Adding the replacement policy ID will be added going forward to all deprecated policies, and as suggested we will remediate those currently deployed as above. Please do always check https://github.com/Azure/Enterprise-Scale/wiki/ALZ-Deprecated-Services and https://github.com/Azure/Enterprise-Scale/wiki/Whats-new for complete history of changes.

vegazbabz commented 1 year ago

We always check that, however, we have script that pulls changes from this repo into our Azure DevOps. So when comparing changes and we can see a policy has been deprecated, then we want to easily just check the other superseding policy without having to search for it. Thanks

Springstone commented 1 year ago

See PR #1388 that will address existing deprecated custom policies with a "supersededBy" metadata property. Kindly also note that AzAdvertizer has been updated with great views and tooling for comparing superseded ALZ policies. Example here: AzAdvertizer

vegazbabz commented 1 year ago

Sounds good, thanks. Feel free to close it from my point of view.