Azure / Enterprise-Scale

The Azure Landing Zones (Enterprise-Scale) architecture provides prescriptive guidance coupled with Azure best practices, and it follows design principles across the critical design areas for organizations to define their Azure architecture
https://aka.ms/alz
MIT License
1.72k stars 978 forks source link

New Feature: Workload Specific Compliance #1622

Closed Springstone closed 6 months ago

Springstone commented 6 months ago

Overview/Summary

This pull request includes significant updates to the Azure Landing Zones (ALZ) policy and the ALZ Portal accelerator. The changes aim to provide additional compliance controls for specific workloads, which are often required by highly regulated industries.

Major changes include:

Updates to .github/workflows/update-portal.yml:

Additions to docs/wiki/ALZ-Policies-Extra.md:

Updates to docs/wiki/Whats-new.md:

Updates to ALZ Portal accelerator:

Updates to Defender for APIs:

Updates to documentation:

Testing Evidence

image

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

Springstone commented 6 months ago

Great work here @Springstone, awesome, awesome work.

Other comments that arent applicable to files:

  1. Have we added metadata.alzVariant for policy definitions to:

    • Pester Tests
    • Contribution Guides
  2. Are we adding tests for all the Deny assignments, into the testing framework that you built?
  3. In the new definitions added should the properties.mode be set to all instead of indexed as per https://learn.microsoft.com/azure/governance/policy/concepts/definition-structure-basics#mode
  4. Do we need to add the properties.version to all our policy definitions now?
  5. Address "secure-by-default" definition concerns and update all policies based on outcome etc.

Addressed all the questions here, and created a user story to create additional Pester tests for the new Deny custom policies we're adding in this PR.