Closed Springstone closed 6 months ago
Great work here @Springstone, awesome, awesome work.
Other comments that arent applicable to files:
Have we added
metadata.alzVariant
for policy definitions to:
- Pester Tests
- Contribution Guides
- Are we adding tests for all the Deny assignments, into the testing framework that you built?
- In the new definitions added should the
properties.mode
be set toall
instead ofindexed
as per https://learn.microsoft.com/azure/governance/policy/concepts/definition-structure-basics#mode- Do we need to add the
properties.version
to all our policy definitions now?- Address "secure-by-default" definition concerns and update all policies based on outcome etc.
Addressed all the questions here, and created a user story to create additional Pester tests for the new Deny custom policies we're adding in this PR.
Overview/Summary
This pull request includes significant updates to the Azure Landing Zones (ALZ) policy and the ALZ Portal accelerator. The changes aim to provide additional compliance controls for specific workloads, which are often required by highly regulated industries.
Major changes include:
Updates to
.github/workflows/update-portal.yml
:src/templates/initiatives.bicep
file and output to./eslzArm/managementGroupTemplates/policyDefinitions/initiatives.json
.Additions to
docs/wiki/ALZ-Policies-Extra.md
:Updates to
docs/wiki/Whats-new.md
:Updates to ALZ Portal accelerator:
docs/wiki/Whats-new.md
: Added a new "Workload Specific Compliance" section to the ALZ Portal accelerator. This new section allows users to apply compliance policies to specific workloads like SQL, Storage, etc. These additional compliance controls are often required by highly regulated industries like financial services and healthcare.Updates to Defender for APIs:
docs/wiki/Whats-new.md
: Updated theDeploy-MDFC-Config
for Defender for APIs, which now requires a sub-plan to be specified. The default sub-plan is "P1", and costs will only be incurred once an API has been onboarded to Defender for APIs. Users are advised to review Defender for API plans as they relate to their environment and adjust the sub-plan as needed.Updates to documentation:
.github/workflows/update-portal.yml
: Added a new step to the workflow to update initiatives in thejobs:
section.docs/wiki/ALZ-Policies-Extra.md
: Added a new file to describe additional policies that are not assigned by default or covered in the core ALZ Policies documentation. This file provides guidance on how to handle certain situations and includes a detailed list of policies and initiatives.Testing Evidence
Testing URLs
Azure Public
As part of this Pull Request I have
main
branch/docs/wiki/whats-new.md
)