Azure / Enterprise-Scale

The Azure Landing Zones (Enterprise-Scale) architecture provides prescriptive guidance coupled with Azure best practices, and it follows design principles across the critical design areas for organizations to define their Azure architecture
https://aka.ms/alz
MIT License
1.69k stars 963 forks source link

Multiregion bugfix #1692

Closed brsteph closed 3 months ago

brsteph commented 3 months ago

Overview/Summary

This PR is to fix issues identified with deploying networks after the multi-region update and recent product changes. Discovered in: https://dev.azure.com/CSUSolEng/Azure%20Landing%20Zones/_workitems/edit/35833

Core issues are:

This PR fixes/adds/changes/removes

  1. Adjusted the logic to better limit the parameters used to initiate a secondary region deployment.

Breaking Changes

  1. None

Testing Evidence

Confirmation of Gateway Deployment: image

Confirmation of single region deployment:

image

ID Spoke and Peering:

image image

Confirmation of DNS Proxy for Secondary Region: image

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

brsteph commented 3 months ago

@jtracey93 - Updated!