Azure / Enterprise-Scale

The Azure Landing Zones (Enterprise-Scale) architecture provides prescriptive guidance coupled with Azure best practices, and it follows design principles across the critical design areas for organizations to define their Azure architecture
https://aka.ms/alz
MIT License
1.73k stars 979 forks source link

Addressing Multi-region bugs for Virtual WAN #1743

Closed brsteph closed 2 months ago

brsteph commented 2 months ago

Overview/Summary

This PR addresses bugs identified with multi-region deployments with Virtual WAN, as identified in the Bug record: AB#36856

The root cause of these are places where location is not correctly being placed for the Virtual WAN deployments, as it is different than Virtual Networks in how and where region is used in some locations.

This PR fixes/adds/changes/removes

  1. Resolves a bug where the programmatic name of the secondary Azure Firewall for Vwan deployments was not correct, creating issues whenever that programmatic name was used.
  2. Resolves a bug where the secondary region's VPN gateway was not being built correctly.

Breaking Changes

  1. None identified.

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Bug errors: image image

These are no longer occurring in testing.

Testing URLs

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

N/A

As part of this Pull Request I have

brsteph commented 2 months ago

Testing confirms that the submitted fix addresses the issue. Ask is to update the What's New page with relevant updates for community awareness.

Added the What's New!