search

Azure / Enterprise-Scale

The Azure Landing Zones (Enterprise-Scale) architecture provides prescriptive guidance coupled with Azure best practices, and it follows design principles across the critical design areas for organizations to define their Azure architecture
https://aka.ms/alz
MIT License
1.72k stars 980 forks source link

Update: LITE DNS Deployment #1753

Closed brsteph closed 2 months ago

brsteph commented 2 months ago

Overview/Summary

A bug was found in #1752 where if you deploy a single region, single subscription with DNS zones, the logic for the DNS zone assignment would trigger it to connect the DNS zones to the hub network trice. The cause was due to the conditional logic using defaults that, even if you selected single region, could still be evaluated. This was changed to use the "binary" Yes/No for the secondary region for evaluation, which matches what was in the multi-subscription deployment.

This PR fixes/adds/changes/removes

  1. Changed the ESLITE deployment to use the enableSecondaryRegion property.

Breaking Changes

  1. None

Testing Evidence

Before:

image

After:

image

Testing URLs

Azure Public

[Deploy To Azure](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Feslz-portal.json)

Azure US Gov (Fairfax)

N/A

As part of this Pull Request I have