Guardrail for Key Vault assignment parameter issue

jasperpostcn commented 3 months ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: 1.9.*

azure provider: v3.114.0

module: CAF version 6.0.0

Description

Describe the bug

After deploying the CAF Enterprise one if the policy assignments that is present by default is the Enforce recommended guardrails for Azure Key Vault. While it is for mostly large initiatives quite hard to map the Policy Texts to the parameter names, in case of the keyvault one it shows multiple parameter with the name Effect. See screenshot for the example.

One improvement I would say is that the Parameter ID can be what it currently is, but the Parameter Name should reflect the names in the assignment so it is easier to map it in code.

Steps to Reproduce

Deploy CAF 6
Go to Policy > Assignments >Enforce recommended guardrails for Azure Key Vault (can be multiple)
Click Edit Assignment and go to Parameters