Azure / Enterprise-Scale

The Azure Landing Zones (Enterprise-Scale) architecture provides prescriptive guidance coupled with Azure best practices, and it follows design principles across the critical design areas for organizations to define their Azure architecture
https://aka.ms/alz
MIT License
1.71k stars 965 forks source link

Bug Report: Deny-MgmtPorts-From-Internet.json #1766

Open rybal06 opened 1 month ago

rybal06 commented 1 month ago

Describe the bug The policy checks for the source address to be * or Internet, but doesn't check for 0.0.0.0/0.

Per https://learn.microsoft.com/en-us/azure/virtual-network/network-security-groups-overview "0.0.0.0/0 in the Source and Destination columns represents all addresses"

Steps to reproduce

  1. Deploy policy in deny mode.
  2. Create an NSG, and allow port 22 from 0.0.0.0/0 address range.
  3. Note, policy is compliant.
jtracey93 commented 1 month ago

@Springstone can you take a look

rybal06 commented 1 month ago

Opened PR: https://github.com/Azure/Enterprise-Scale/pull/1768