Azure / Enterprise-Scale

The Azure Landing Zones (Enterprise-Scale) architecture provides prescriptive guidance coupled with Azure best practices, and it follows design principles across the critical design areas for organizations to define their Azure architecture
https://aka.ms/alz
MIT License
1.72k stars 980 forks source link

Fixes deployment validation error when LAW is not deployed, and AMBA is enabled #1820

Closed arjenhuitema closed 2 weeks ago

arjenhuitema commented 2 weeks ago

Overview/Summary

Fixes a bug in the Portal Accelerator that causes deployment validation to fail with the error message "The 'location' property must be specified for 'amba-id-amba-prod-001'". This event happens when a Log Analytics Workspace is not deployed, but Azure Monitor Baseline Alerts is enabled. This issue occurs because Azure Monitor Baseline Alerts depends on the management subscription, which is not provided if the Log Analytics Workspace is not deployed. To address this scenario, an additional section was implemented in the Baseline alerts and monitoring tab allowing the selection of a Management subscription when not deploying a Log Analytics Workspace.

image

This PR fixes/adds/changes/removes

  1. Added a new Management subscription section that is visible only if AMBA is deployed and LAW is not.
  2. Updated logic for Management subscription output.

Breaking Changes

None

Testing Evidence

Single subscription with LAW

Deployment image

AMBA UAMI deployed to single platform subscription image

Single subscription no LAW

Deployment image

AMBA UAMI deployed to single platform subscription image

Dedicated subscriptions with LAW

Deployment image

AMBA UAMI deployed to management subscription image

Dedicated subscriptions no LAW, with Management subscription selection in Monitoring section

Deployment image

AMBA UAMI deployed to management subscription image

Dedicated subscriptions no LAW, no Management subscription selection in Monitoring section

Deployment image

In this case the AMBA UAMI is not deployed.

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have