Azure / Enterprise-Scale

The Azure Landing Zones (Enterprise-Scale) architecture provides prescriptive guidance coupled with Azure best practices, and it follows design principles across the critical design areas for organizations to define their Azure architecture
https://aka.ms/alz
MIT License
1.72k stars 980 forks source link

feat: allow single parameter dns zone policy #1821

Closed jaredfholgate closed 2 weeks ago

jaredfholgate commented 2 weeks ago

Overview/Summary

A backwards compatible update to the Deploy-Private-DNS-Zones policy set definition.

This enables passing a subscription id, resource group name and region to automatically generate the resource ids for the policy definitions.

This PR fixes/adds/changes/removes

N/A

Breaking Changes

None, designed to be backwards compatible

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

Deploy To Azure

Azure US Gov (Fairfax)

Deploy To Azure

As part of this Pull Request I have

matt-FFFFFF commented 2 weeks ago

I get this error when trying to deploy the policy set. Investigating...

Bad Request({"error":{"code":"InvalidPolicyParameters","message":"A function or parameter in policy set or assignment 'Deploy-Private-DNS-Zones' associated with the policy definition '06695360-db88-47f6-b976-7500d4297475' could not be validated. If using template functions, try following the tips in: https://aka.ms/policy-avoiding-template-failures. The inner exception 'The language expression property '' doesn't exist, available properties are 'uaenorth, northcentralus, malaysiawest, eastus, uksouth, westcentralus, israelcentral, southeastasia, malaysiasouth, koreacentral, northeurope, australiaeast, southafricanorth, norwaywest, norwayeast, westus3, eastus2euap, centralus, mexicocentral, canadacentral, japaneast, swedencentral, taiwannorth, germanynorth, centralindia, westindia, newzealandnorth, australiacentral, ukwest, germanywestcentral, brazilsouth, francecentral, brazilsoutheast, westus2, eastus2, centraluseuap, australiacentral2, francesouth, southafricawest, koreasouth, southindia, canadaeast, qatarcentral, spaincentral, westeurope, japanwest, southcentralus, polandcentral, switzerlandwest, australiasoutheast, switzerlandnorth, italynorth, uaecentral, eastasia, chilecentral, westus, swedensouth'.'."}})

jaredfholgate commented 2 weeks ago

I get this error when trying to deploy the policy set. Investigating...

Bad Request({"error":{"code":"InvalidPolicyParameters","message":"A function or parameter in policy set or assignment 'Deploy-Private-DNS-Zones' associated with the policy definition '06695360-db88-47f6-b976-7500d4297475' could not be validated. If using template functions, try following the tips in: https://aka.ms/policy-avoiding-template-failures. The inner exception 'The language expression property '' doesn't exist, available properties are 'uaenorth, northcentralus, malaysiawest, eastus, uksouth, westcentralus, israelcentral, southeastasia, malaysiasouth, koreacentral, northeurope, australiaeast, southafricanorth, norwaywest, norwayeast, westus3, eastus2euap, centralus, mexicocentral, canadacentral, japaneast, swedencentral, taiwannorth, germanynorth, centralindia, westindia, newzealandnorth, australiacentral, ukwest, germanywestcentral, brazilsouth, francecentral, brazilsoutheast, westus2, eastus2, centraluseuap, australiacentral2, francesouth, southafricawest, koreasouth, southindia, canadaeast, qatarcentral, spaincentral, westeurope, japanwest, southcentralus, polandcentral, switzerlandwest, australiasoutheast, switzerlandnorth, italynorth, uaecentral, eastasia, chilecentral, westus, swedensouth'.'."}})

Thanks for testing it. I will take a look too and try to fix it. :)