search

Azure / GuestConfiguration

PowerShell module for creating, testing, and publishing custom Guest Configuration
MIT License
5 stars 2 forks source link

Old cmdlet shouldn’t be broken because of new experimental feature #217

Closed amitsara closed 3 years ago

amitsara commented 3 years ago

Repro steps:

  1. Install latest released module.
  2. Do not enable experimental feature
  3. Run test cmdlet.

Result: Cmdlet is throwing a weird error PS /home/azureuser/ps72> Test-GuestConfigurationPackage -path /home/azureuser/AzureDockerBaseline.zip -Verbose Test-GuestConfigurationPackage: The term 'Install-GuestConfigurationPackage' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. Suggestion [4,General]: The most similar commands are: Test-GuestConfigurationPackage.

If I enable ‘GuestConfiguration.SetScenario’ , then it works fine

Expected: Old cmdlets (New-GuestConfigurationPackage, Test-GuestConfigurationPackage, New-GuestConfigurationPolicy, publish-GuestConfigurationPolicy) should not need customer to enable experimental feature New release will break customer automation.

gaelcolas commented 3 years ago

The experimental feature flag adds more complexity, I'd rather increment the Major section of the version. The old Test is a Get, and this version corrects this. Backward compatibility is an hindrance to good UX here.

github-actions[bot] commented 3 years ago

This issue has not been updated within 14 days