few changes in vue to OSS the module as per discussed with Nitin

Azure / GuestConfiguration

PowerShell module for creating, testing, and publishing custom Guest Configuration

MIT License

5 stars 2 forks source link

few changes in vue to OSS the module as per discussed with Nitin #265

Closed gaelcolas closed 1 year ago

gaelcolas commented 2 years ago

Discussed with @nitinbps and he asked I clean up the repo in vue to have the repo ready to go public. I've changed the contributing.md saying we can't accept them. I've cleaned up some unused file (please make sur the private pipeline is deleted if not in use anymore). I've fixed the Changelog file to be keepachangelog compliant

If there's more cleanup you can think of, let me know.

gaelcolas commented 2 years ago

Build fails because now probably because the pipeline has a wrong/old GitHubToken variable set as pipeline variable. AFAICT, the task is not used anymore anyway as the "other" job is pulling the artifact from the other pipeline artifact.

Because of this, even if we skip the download_gc_agents, some unit test will fail. Shall we -skip those tests for now? or how shall we proceed? ATM, we can't build and test in this AzDO pipeline. /cc @kwirkykat

github-actions[bot] commented 2 years ago

This PR has not been updated within 14 days