search

Azure / GuestProxyAgent

MIT License
2 stars 9 forks source link

Typo in name sock_addr_aduit_key #55

Open setharnold opened 3 months ago

setharnold commented 3 months ago

https://github.com/Azure/GuestProxyAgent/blob/c47351bff371eb73f9ea6346c70953a023fc5e98/linux-ebpf/ebpf_cgroup.c#L29C17-L29C36

Hello, there appears to be a typo in the name sock_addr_aduit_key, which should probably be audit.

I recommend installing an action like https://www.check-spelling.dev/ to help find mistakes during development rather than when you find features are missing or have never been tested, etc.

Thanks

ZhidongPeng commented 2 months ago

Thanks, fixed here https://github.com/Azure/GuestProxyAgent/pull/67

balakreddy commented 2 months ago

@ZhidongPeng I didn't notice it was assigned to you. If you are working on the github action along with the typos. I can close the pull request https://github.com/Azure/GuestProxyAgent/pull/68

balakreddy commented 2 months ago

@setharnold and @ZhidongPeng I added the github action for spell check as part of #68. It highlighted good number of typos I am planning to fix all the typos. I will be sending the single PR. If it is too big, will split it and send out separate PRs.

balakreddy commented 2 months ago

Additional pull request #69 which fixes some of the typos based on the results from #68