search

Azure / InnovationEngine

An experiment in simplicity for complex environments
MIT License
35 stars 18 forks source link

Spinning wheel animation spamming scenario testing output #66

Open vmarcella opened 1 year ago

vmarcella commented 1 year ago

The github actions terminal doesn't support us rendering characters in place so the spinning wheel animation used to indicate the progress of a command/step renders across multiple lines instead of on one.

nellyk commented 3 months ago

@vmarcella our team is currently using this for github actions. Did this get resolved for you?

rgardler-msft commented 3 months ago

Assuming this is not a simple fix, can we add a command line switch to prevent the animation effect. Even better if we can detect if the terminal being run in supports in-place. When disabled the animation would be replaced by an ever growing "...." output

zioproto commented 3 months ago

The ie test command has the following options:

Global Flags:
      --environment string    The environment that the CLI is running in. (local, ci, ocd) (default "local")

Should the ci option the one to be used for GitHub actions ? What is ocd ?

mbifeld commented 3 months ago

The spinning wheel issue should be resolved in the ie test UX refresh in this PR: https://github.com/Azure/InnovationEngine/pull/198

mbifeld commented 3 months ago

@vmarcella can you clarify if ci flag should be used for GitHub Actions?

@zioproto ocd stands for "one click deploy" and is used internally by Portal team. It should probably be removed from the public help command details.

Made an issue for improving the details in ie __ --help here: https://github.com/Azure/InnovationEngine/issues/201.

vmarcella commented 3 months ago

The spinning wheel issue for ie test is going to be fixed in #198.

As for the --environment, I wouldn't worry about setting it for ie test as the default parameter will suffice and ie test doesn't actually treat the environments as different (ie execute and ie interactive do, though). I will update the documentation in a future PR to better describe when to modify the environment flag.