Azure / LinuxPatchExtension

Microsoft Azure VM Guest Linux Patch Extension
Apache License 2.0
10 stars 8 forks source link

Bugfix for out-of-date package lists causing install failures #252

Closed kjohn-msft closed 7 months ago

kjohn-msft commented 7 months ago

There is a non-obvious bug caused by performance-enhancing code that was added 6-7 years ago.

Local package lists are left in a state inconsistent against subsequent installation intent because of the sequence of execution of code. This results in us invoking installation actions based on what we have in memory from a prior call while the system is not in the same state.

This never affected operations installing security updates only. It sometimes affected operations installing all updates based on the relative state of repositories (security vs. all others). It most recently reproduced consistently on Ubuntu 22.04.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.98%. Comparing base (c58b9aa) to head (a9429b6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #252 +/- ## ======================================= Coverage 90.98% 90.98% ======================================= Files 91 91 Lines 15737 15737 ======================================= Hits 14318 14318 Misses 1419 1419 ``` | [Flag](https://app.codecov.io/gh/Azure/LinuxPatchExtension/pull/252/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Azure) | Coverage Δ | | |---|---|---| | [python27](https://app.codecov.io/gh/Azure/LinuxPatchExtension/pull/252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Azure) | `90.98% <100.00%> (ø)` | | | [python39](https://app.codecov.io/gh/Azure/LinuxPatchExtension/pull/252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Azure) | `90.98% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Azure#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kjohn-msft commented 7 months ago

Merging as an exception due to hotfix.