search

Azure / LinuxPatchExtension

Microsoft Azure VM Guest Linux Patch Extension
Apache License 2.0
10 stars 8 forks source link

Expanding support for yum install --assumeno cmd to include yum4 #272

Open rane-rajasi opened 6 days ago

rane-rajasi commented 6 days ago

Problem statement: Yum 3 and Yum 4 have different output syntax for yum install --assumeno cmd, which used to get dependent packages. Existing implementation was syntax specific, covering only yum 3 scenarios resulting in all dependent packages within yum 4 to NOT be identified. Since dependent packages were never identified in yum 4, any exclusion rules on these were never applied, causing excluded packages to also get installed.

Fix: Adding capability to read o/p format of the cmd in yum 4.

Tests

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 91.54930% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.11%. Comparing base (82f45bb) to head (04e5642).

Files with missing lines Patch % Lines
src/core/tests/library/LegacyEnvLayerExtensions.py 76.92% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #272 +/- ## ======================================= Coverage 91.10% 91.11% ======================================= Files 91 91 Lines 15893 15952 +59 ======================================= + Hits 14480 14534 +54 - Misses 1413 1418 +5 ``` | [Flag](https://app.codecov.io/gh/Azure/LinuxPatchExtension/pull/272/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Azure) | Coverage Δ | | |---|---|---| | [python27](https://app.codecov.io/gh/Azure/LinuxPatchExtension/pull/272/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Azure) | `91.11% <91.54%> (+<0.01%)` | :arrow_up: | | [python39](https://app.codecov.io/gh/Azure/LinuxPatchExtension/pull/272/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Azure) | `91.11% <91.54%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Azure#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.