Azure / LogicAppsUX

https://learn.microsoft.com/azure/logic-apps
MIT License
73 stars 80 forks source link

Vs code_Bundle_nuget_Custom Http Timeout Setting Per Request Action : Workflow is getting validated without showing error after changing the code in compose action #1971

Closed vgouth closed 1 year ago

vgouth commented 1 year ago

Describe the Bug with repro steps

1.Create a standard logic app 2.Create an empty stateless workflow 3.Add a request trigger and compose action 4.Save the workflow 5.Open the code tab and replace the compose action with the following JSON: "Compose": {

"inputs": "test",
"runAfter": {},
"runtimeConfiguration": { "requestOptions": { "timeout": "PT24H" } },
"type": "Compose"

} 6.Save the workflow Expected Result: The following error should be displayed: "The request options timeout parameter is not supported for action 'Compose' of type 'Compose'. Actions of type 'HTTP' are supported. Actual Result : Workflow is getting validated without showing error after changing the code in compose action. There is change in code for compose action in workflow.json as well after saving it and debugging it .

Workflow JSON

{
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "actions": {
            "Compose": {
                "type": "Compose",
                "inputs": "abcd",
                "runAfter": {}
            }
        },
        "contentVersion": "1.0.0.0",
        "outputs": {},
        "triggers": {
            "When_a_HTTP_request_is_received": {
                "type": "Request",
                "kind": "Http"
            }
        }
    },
    "kind": "Stateless"
}

Screenshots or Videos

image

Browser

VS code

Additional context

VS Code extension - ​vsix icon vscode-azurelogicapps-2.0.26.vsix NuGet package: https://artprodeussu2.artifacts.visualstudio.com/A41bf5486-7392-4b7a-a7e3-a735c767e3b3/b32aa71e-8ed2-41b2-9d77-5bc261222004/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL21zYXp1cmUvcHJvamVjdElkL2IzMmFhNzFlLThlZDItNDFiMi05ZDc3LTViYzI2MTIyMjAwNC9idWlsZElkLzcxMzU5ODUxL2FydGlmYWN0TmFtZS9kcm9wX2J1aWxkX0J1aWxkQXJ0aWZhY3RzX1dpbmRvd3M1/content?format=file&subPath=%2FMicrosoft.Azure.Workflows.WebJobs.Extension.1.17.1.nupkg Extension Bundle (CDN URL): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting Extension Bundle (Direct Download): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting/ExtensionBundles/Microsoft.Azure.Functions.ExtensionBundle.Workflows/1.17.1/Microsoft.Azure.Functions.ExtensionBundle.Workflows.1.17.1_any-any.zip

vgouth commented 1 year ago

Artifacts Details :

  1. VS Code extension - vscode-azurelogicapps-2.9.1.vsix
  2. NuGet package: https://artprodeussu2.artifacts.visualstudio.com/A41bf5486-7392-4b7a-a7e3-a735c767e3b3/b32aa71e-8ed2-41b2-9d77-5bc261222004/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL21zYXp1cmUvcHJvamVjdElkL2IzMmFhNzFlLThlZDItNDFiMi05ZDc3LTViYzI2MTIyMjAwNC9idWlsZElkLzcyMDcxNTQ1L2FydGlmYWN0TmFtZS9kcm9wX2J1aWxkX0J1aWxkQXJ0aWZhY3RzX1dpbmRvd3M1/content?format=file&subPath=%2FMicrosoft.Azure.Workflows.WebJobs.Extension.1.19.1.nupkg
  3. Extension Bundle (CDN URL): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting
  4. Extension Bundle (Direct Download): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting/ExtensionBundles/Microsoft.Azure.Functions.ExtensionBundle.Workflows/1.19.1/Microsoft.Azure.Functions.ExtensionBundle.Workflows.1.19.1_any-any.zip

We are not able to repro this bug in new artifact.

image

vgouth commented 1 year ago

Closing this bug after confirmation from Eric as this is not repro in new artifact.