Azure / LogicAppsUX

https://learn.microsoft.com/azure/logic-apps
MIT License
75 stars 81 forks source link

Standard_Custom Http Timeout Setting Per Request Action: The HTTP Request action showing as Success without validation error #2039

Closed vgouth closed 1 year ago

vgouth commented 1 year ago

Describe the Bug with repro steps

1.Create a standard logic app 2.Create an empty stateless workflow 3.Add a request trigger and HTTP request action. 4.The request url to point to (https://httptimeoutendpoint.azurewebsites.net:443/api/longresponse/triggers/manual/invoke?api-version=2020-05-01-preview&sp=%2ftriggers%2fmanual%2frun&sv=1.0&sig=BiCOpndJgI4xnNMW0n1MkN0NgRPgcH0NIK-h8NStZrI) 5.Go to settings tab and set Request options to PT24H 6.Disable the Asynchronous pattern. 7.Save and run the workflow. 8.Expected Result: The workflow should save and present a validation error "The provided request options timeout of '24:00:00' for action 'HTTP' must be less than '01:00:00' Actual Result: The HTTP Request action showing as Success without validation error.

Another Scenario

  1. Again change the Request options to InvalidString 10.Expected Result: The string InvalidString is not a valid timespan value. Actual Result: The HTTP Request action showing as Success without validation error.

Note: Looks like changing the Request options to PT1S is not sa

Workflow JSON

{
  "definition": {
    "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
    "actions": {
      "HTTP": {
        "type": "Http",
        "inputs": {
          "uri": "https://httptimeoutendpoint.azurewebsites.net:443/api/longresponse/triggers/manual/invoke?api-version=2020-05-01-preview&sp=%2Ftriggers%2Fmanual%2Frun&sv=1.0&sig=BiCOpndJgI4xnNMW0n1MkN0NgRPgcH0NIK-h8NStZrI",
          "method": "POST"
        },
        "runAfter": {},
        "limit": {
          "timeout": "PT24H"
        }
      }
    },
    "contentVersion": "1.0.0.0",
    "outputs": {},
    "triggers": {
      "When_a_HTTP_request_is_received": {
        "type": "Request",
        "kind": "Http"
      }
    }
  },
  "connectionReferences": {},
  "parameters": {}
}

Another Scenario JSON code

{
  "definition": {
    "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
    "actions": {
      "HTTP": {
        "type": "Http",
        "inputs": {
          "uri": "https://httptimeoutendpoint.azurewebsites.net:443/api/longresponse/triggers/manual/invoke?api-version=2020-05-01-preview&sp=%2Ftriggers%2Fmanual%2Frun&sv=1.0&sig=BiCOpndJgI4xnNMW0n1MkN0NgRPgcH0NIK-h8NStZrI",
          "method": "POST"
        },
        "runAfter": {},
        "limit": {
          "timeout": "InvalidString"
        }
      }
    },
    "contentVersion": "1.0.0.0",
    "outputs": {},
    "triggers": {
      "When_a_HTTP_request_is_received": {
        "type": "Request",
        "kind": "Http"
      }
    }
  },
  "connectionReferences": {},
  "parameters": {}
}

Screenshots or Videos

image image

Browser

Edge

Additional context

Environmental Details:

URL: https://aka.ms/emastaging-flowsEurope Version : 2.30410.1.3

vgouth commented 1 year ago

Issue repro in latest artifact.

  1. VS Code extension - vscode-azurelogicapps-2.9.1.vsix
  2. NuGet package: https://artprodeussu2.artifacts.visualstudio.com/A41bf5486-7392-4b7a-a7e3-a735c767e3b3/b32aa71e-8ed2-41b2-9d77-5bc261222004/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL21zYXp1cmUvcHJvamVjdElkL2IzMmFhNzFlLThlZDItNDFiMi05ZDc3LTViYzI2MTIyMjAwNC9idWlsZElkLzcyMDcxNTQ1L2FydGlmYWN0TmFtZS9kcm9wX2J1aWxkX0J1aWxkQXJ0aWZhY3RzX1dpbmRvd3M1/content?format=file&subPath=%2FMicrosoft.Azure.Workflows.WebJobs.Extension.1.19.1.nupkg
  3. Extension Bundle (CDN URL): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting
  4. Extension Bundle (Direct Download): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting/ExtensionBundles/Microsoft.Azure.Functions.ExtensionBundle.Workflows/1.19.1/Microsoft.Azure.Functions.ExtensionBundle.Workflows.1.19.1_any-any.zip
preetriti1 commented 1 year ago

This cannot be reproduced now after fixing the setting for Http, it was incorrectly showing Asynchronus response instead of pattern and validation run by service would show the error for invalidstring and invalid timespan. The fix for setting name should be present in our next release by end of May.

vgouth commented 1 year ago

Issue repro in latest artifact.

  1. VS Code extension - vscode-azurelogicapps-2.15.10.vsix
  2. NuGet package: https://artprodeussu2.artifacts.visualstudio.com/A41bf5486-7392-4b7a-a7e3-a735c767e3b3/b32aa71e-8ed2-41b2-9d77-5bc261222004/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL21zYXp1cmUvcHJvamVjdElkL2IzMmFhNzFlLThlZDItNDFiMi05ZDc3LTViYzI2MTIyMjAwNC9idWlsZElkLzcyNDMyOTY3L2FydGlmYWN0TmFtZS9kcm9wX2J1aWxkX0J1aWxkQXJ0aWZhY3RzX1dpbmRvd3M1/content?format=file&subPath=%2FMicrosoft.Azure.Workflows.WebJobs.Extension.1.19.4.nupkg
  3. Extension Bundle (CDN URL): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting
  4. Extension Bundle (Direct Download): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting/ExtensionBundles/Microsoft.Azure.Functions.ExtensionBundle.Workflows/1.19.4/Microsoft.Azure.Functions.ExtensionBundle.Workflows.1.19.4_any-any.zip
  5. Resources vsix.
    vscode-azureresourcegroups-LA.vsix

image

vgouth commented 1 year ago

Issue repro in the latest request:

Environment Details: URL: https://aka.ms/emastaging-flowstip1 Version: 2.30508.1.2

image image

Note: We are able to see Asynchronus pattern instead of Asynchronus response. This issue is resolved.

vgouth commented 1 year ago

Issue repro in latest artifact.

1,VS Code extension – vscode-azurelogicapps-2.15.15.vsix 2.NuGet package: https://artprodeussu2.artifacts.visualstudio.com/A41bf5486-7392-4b7a-a7e3-a735c767e3b3/b32aa71e-8ed2-41b2-9d77-5bc261222004/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL21zYXp1cmUvcHJvamVjdElkL2IzMmFhNzFlLThlZDItNDFiMi05ZDc3LTViYzI2MTIyMjAwNC9idWlsZElkLzczMDA5ODA5L2FydGlmYWN0TmFtZS9kcm9wX2J1aWxkX0J1aWxkQXJ0aWZhY3RzX1dpbmRvd3M1/content?format=file&subPath=%2FMicrosoft.Azure.Workflows.WebJobs.Extension.1.21.3.nupkg 3.Extension Bundle (CDN URL): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting 4.Extension Bundle (Direct Download): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting/ExtensionBundles/Microsoft.Azure.Functions.ExtensionBundle.Workflows/1.21.3/Microsoft.Azure.Functions.ExtensionBundle.Workflows.1.21.3_any-any.zip 5.Resources vsix. vscode-azureresourcegroups-LA.vsix

image

Note: We are able to see Asynchronus pattern instead of Asynchronus response. This issue is resolved.

ccastrotrejo commented 1 year ago

This issue works fine in portal, it's just repro in VSCode. Will fix it and update the issue thread once it is solved.

vgouth commented 1 year ago

Issue repro in latest artifact.

1.VS Code extension: vscode-azurelogicapps-2.18.0.vsix 2.NuGet package: https://artprodeussu2.artifacts.visualstudio.com/A41bf5486-7392-4b7a-a7e3-a735c767e3b3/b32aa71e-8ed2-41b2-9d77-5bc261222004/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL21zYXp1cmUvcHJvamVjdElkL2IzMmFhNzFlLThlZDItNDFiMi05ZDc3LTViYzI2MTIyMjAwNC9idWlsZElkLzczNTE1ODYzL2FydGlmYWN0TmFtZS9kcm9wX2J1aWxkX0J1aWxkQXJ0aWZhY3RzX1dpbmRvd3M1/content?format=file&subPath=%2FMicrosoft.Azure.Workflows.WebJobs.Extension.1.23.1.nupkg 3.Extension Bundle (CDN URL): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting 4.Extension Bundle (Direct Download): https://cdnforlogicappsv2.blob.core.windows.net/logicapps-vendortesting/ExtensionBundles/Microsoft.Azure.Functions.ExtensionBundle.Workflows/1.23.1/Microsoft.Azure.Functions.ExtensionBundle.Workflows.1.23.1_any-any.zip

image

vgouth commented 1 year ago

Issue repro in the latest portal request as well:

Environment Details: URL: https://aka.ms/emastaging-flowstip1 Version: 2.30529.1.1

image image

ccastrotrejo commented 1 year ago

Hey @vgouth, the step 5 from the description says Go to settings tab and set Request options to PT24H and it seems from the screenshots that the invalidString and PT24h are written in the Action Timeout in the general area. Can we agree which one is the right one? I tried in the Request Options and both show the error validation notification in porta. In vscode is still pending work

Screenshot 2023-05-31 at 11 56 25 AM Screenshot 2023-05-31 at 11 56 08 AM
ccastrotrejo commented 1 year ago

As an update on this. Issue seems to be in validate API when saving the workflow in vscode

vgouth commented 1 year ago

@ccastrotrejo - Yes, now we are able to see the Request options tab under networking which is the right one. I tried to change the timeout to PT24H but the validation error we are getting not similar to previous one. But in invalidString case we are getting the same error.

image

ccastrotrejo commented 1 year ago

@ccastrotrejo - Yes, now we are able to see the Request options tab under networking which is the right one. I tried to change the timeout to PT24H but the validation error we are getting not similar to previous one. But in invalidString case we are getting the same error.

image

@vgouth this screenshot is fine since the PT24h it's not a valid timespan it should be PT24H,

vgouth commented 1 year ago

@ccastrotrejo , I have checked with PT24H timespan but the validation error, getting is different (The provided request options timeout of '1.00:00:00' for action 'HTTP' must be less '00:03:45'."}}) when compared to previous one ("The provided request options timeout of '24:00:00' for action 'HTTP' must be less than '01:00:00'). Is this the expected one for the new designer ?

image

hartra344 commented 1 year ago

This new error is coming from the backend validation, not front end. It appears to be expected.