Azure / LogicAppsUX

https://learn.microsoft.com/azure/logic-apps
MIT License
77 stars 83 forks source link

Stateless workflow until loop timeout defaults to 1 hour instead of 5 minutes #2166

Closed yoHasse closed 8 months ago

yoHasse commented 1 year ago

Describe the Bug

When creating a stateless workflow in the VS Code extension and then adding an Until loop it sets the Timeout value to PT1H as default. This is violating the maximum allowed time that a stateless workflow can run (5 minutes).

This results in some strange error messages and after some digging in the error logs I found the reference to that setting.

Plan Type

Standard

Steps to Reproduce the Bug or Issue

  1. Create a new stateless workflow in any project.
  2. Add an until loop.
  3. Expand the "Change Limits" and see that the Timout setting is set to PT1H (1 hour)

Workflow JSON

{
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "actions": {
            "Until": {
                "type": "Until",
                "expression": "@equals('', '')",
                "limit": {
                    "count": 60,
                    "timeout": "PT1H"
                },
                "actions": {},
                "runAfter": {}
            }
        },
        "triggers": {
            "manual": {
                "type": "Request",
                "kind": "Http",
                "inputs": {}
            }
        },
        "contentVersion": "1.0.0.0",
        "outputs": {}
    },
    "kind": "Stateless"
}

Screenshots or Videos

image

Additional context

No response

AB#16636564

rohithah commented 1 year ago

@hartra344 - we need to update the default value we are setting here to be different for stateless workflows

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 45 days with no activity.

yoHasse commented 1 year ago

Bump

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 45 days with no activity.

yoHasse commented 1 year ago

Ping

hartra344 commented 1 year ago

This is something we're tracking on our backlog but would be a bit involved since we don't have the concept of stateful vs stateless where this is set. This likely won't be changing until later in the summer. Also moving this to the UX repo so we can respond when it's out

preetriti1 commented 1 year ago

The default values are in the manifest, so when these manifests are sent by the backend apis it can set the value correctly, the client cannot conditionally set this based on workflow type since it is just a parameter value

azure-boards[bot] commented 8 months ago

❌ There was a problem linking to Azure Boards work item(s):

Please check the IDs and try again using the AB# syntax. Learn more

azure-boards[bot] commented 8 months ago

❌ There was a problem linking to Azure Boards work item(s):

Please check the IDs and try again using the AB# syntax. Learn more

azure-boards[bot] commented 8 months ago

❌ There was a problem linking to Azure Boards work item(s):

Please check the IDs and try again using the AB# syntax. Learn more

azure-boards[bot] commented 8 months ago

❌ There was a problem linking to Azure Boards work item(s):

Please check the IDs and try again using the AB# syntax. Learn more