search

Azure / LogicAppsUX

https://learn.microsoft.com/azure/logic-apps
MIT License
77 stars 84 forks source link

Even after disabling "Static Result" white beaker icon is still visible on Action Card. #4930

Open Aleks-gdb opened 5 months ago

Aleks-gdb commented 5 months ago

Describe the Bug with repro steps

  1. Go to create a new cloud flow
  2. Select manually trigger a flow or recurrence and add an action "Send an email(V2)".

  3. Click on the Ellipsis on Action Card and enable Static Result toggle button. A White beaker icon will be visible indicating 'Static Result is enable'.

    4 Now disable Static Result toggle button and Observe the beaker icon does not get removed from the action card.

What type of Logic App Is this happening in?

Power Automate

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

No response

Screenshots or Videos

Note how the icon does not go away after the feature gets disabled

image

Browser

Edge

Additional context

No response

Eric-B-Wu commented 5 months ago

This is because static results is built outside of the action itself, so once an action is saved with a static results, it can only be enabled/disabled. I believe this was the same interaction in old designer - where users can enable it and have their existing presets - which was why I kept it as so. We can discuss between PA and LA if there is a way we can delete the static result that is linked to a node altogether without losing the original functionality

wsilveiranz commented 4 months ago

@Eric-B-Wu, I also had a customer reporting this behavior. I understand that static result is kept outside the action, so you can enable and disable as you want, but from a functionality point of view:

  1. The icon should reflect if the static result is enabled or disabled? Someone reviewing a run history will not know for sure if the data returned was from the static result or not if there is no indication if the result is required anymore.
  2. We could provide a facility to remove a static result. If it is created for lower environments, when moving a workflow to production it will require manipulation of the json file in order to not take this to upper environments.
Eric-B-Wu commented 4 months ago

I think something what we can do is,

  1. Remove the icon based on whether or not the static results is enabled/disabled for the node that way there won't be that confusion
  2. An option on the node menu options to delete the static results that way users can remove static results from the workflow json without actually having to go directly into code view