Azure / LogicAppsUX

https://learn.microsoft.com/azure/logic-apps
MIT License
75 stars 81 forks source link

Loop Concurrency Control resets back to default after page refresh. Doesn't maintain the previous saved setting. #5058

Closed JimschMsft closed 3 months ago

JimschMsft commented 3 months ago

Describe the Bug with repro steps

Create a Loop, such as a for loop. Turn on the concurrency Control, set degree of Parallelism to 1. Save. It maintains during the same session. However, after page refresh, the concurrency control has reset.

I've added a repro video

What type of Logic App Is this happening in?

Consumption (Portal)

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

{
  "definition": {
    "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
    "actions": {
      "Initialize_MyStringValue": {
        "type": "InitializeVariable",
        "inputs": {
          "variables": [
            {
              "name": "MyStringValue",
              "type": "string",
              "value": "'10040','10069','10072','10117','20600','20672','20846','20847','20924','21507','22175','22501','22568','22688','22715','22294','24271','24801','26225','26841','27045','27901','27903','27183','29028','29932','31759','31973'"
            }
          ]
        },
        "runAfter": {}
      },
      "Initialize_MyArray": {
        "type": "InitializeVariable",
        "inputs": {
          "variables": [
            {
              "name": "MyArray",
              "type": "array"
            }
          ]
        },
        "runAfter": {
          "Initialize_MyStringValue": [
            "SUCCEEDED"
          ]
        }
      },
      "Initialize_Temp": {
        "type": "InitializeVariable",
        "inputs": {
          "variables": [
            {
              "name": "Temp",
              "type": "string"
            }
          ]
        },
        "runAfter": {
          "Initialize_MyArray": [
            "SUCCEEDED"
          ]
        }
      },
      "Split_String_into_an_Array": {
        "type": "SetVariable",
        "inputs": {
          "name": "MyArray",
          "value": "@split(variables('MyStringValue'),',')"
        },
        "runAfter": {
          "Initialize_Temp": [
            "SUCCEEDED"
          ]
        }
      },
      "For_each": {
        "type": "Foreach",
        "foreach": "@variables('MyArray')",
        "actions": {
          "Set_Temp_to_Current_Item": {
            "type": "SetVariable",
            "inputs": {
              "name": "Temp",
              "value": "@{items('For_each')}"
            }
          }
        },
        "runAfter": {
          "Split_String_into_an_Array": [
            "SUCCEEDED"
          ]
        }
      },
      "End": {
        "type": "SetVariable",
        "inputs": {
          "name": "Temp",
          "value": "Done"
        },
        "runAfter": {
          "For_each": [
            "SUCCEEDED"
          ]
        }
      }
    },
    "contentVersion": "1.0.0.0",
    "outputs": {},
    "triggers": {
      "Recurrence": {
        "type": "Recurrence",
        "recurrence": {
          "interval": 10,
          "frequency": "Month"
        }
      }
    }
  },
  "connectionReferences": {},
  "parameters": {}
}

Screenshots or Videos

https://github.com/Azure/LogicAppsUX/assets/46939156/c30766cd-0054-4e6a-a6b5-42db1846ea60

Browser

Edge Version 126.0.2592.81 (Official build) (64-bit)

Additional context

No response

DanielleCogs commented 3 months ago

Doing some initial investigation- seems like the value is being updated correctly, we are getting the correct value from the backend. This happens for any set concurrency number, not just 1.

DanielleCogs commented 3 months ago

Most likely related to this recent PR https://github.com/Azure/LogicAppsUX/commit/691fdbb760bb8978eb9e33e10219e853b1d03490

DanielleCogs commented 3 months ago

In the process of rolling back deployment to fix this issue. Should be resolved by EOD.

DanielleCogs commented 3 months ago

Resolved with the rollback, code fix is in progress