search

Azure / LogicAppsUX

https://learn.microsoft.com/azure/logic-apps
MIT License
75 stars 81 forks source link

msla-designer-canvas is not using 100% side of parent #5704

Closed Xiaoyu-Huang closed 1 month ago

Xiaoyu-Huang commented 1 month ago

Describe the Bug with repro steps

I am trying to adopt the latest version 4.94.0. I noticed that the designer cannot be rendered. after debugging, I noticed some class styling change which caused the designer cavas isn't using 100% of parent, The version we used earlier is 4.51.5

"@microsoft/logic-apps-designer": "4.94.0",

"@microsoft/logic-apps-shared": "4.94.0",

image

What type of Logic App Is this happening in?

Consumption (Portal)

Which operating system are you using?

Windows

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

No response

Screenshots or Videos

No response

Browser

Edge

Additional context

No response

rllyy97 commented 1 month ago

Hi @Xiaoyu-Huang, this was an intended breaking change as part of this PR: https://github.com/Azure/LogicAppsUX/pull/5397 Instead of using height: 100% we have flex: 1 instead, you should be able to wrap the designer component in a flex box to have it fill the space again