search

Azure / Microsoft.Azure.StackExchangeRedis

Azure-specific wrapper for the StackExchange.Redis client library
MIT License
17 stars 14 forks source link

Is there any plan to support new version of Microsoft.Identity.Client? #15

Closed wakinpang closed 1 year ago

wakinpang commented 1 year ago

since my project used 4.55 version of Microsoft.Identity.Client, there is some dependency problem about can't resolve right method. And as I checked, the method in it ManagedIdentityApplicationBuilder.Create has changed (they changed the method's parameter, but do not support the old one), does not support use a string parameter directly.

It's OK for me, I can downgrade my package reference to 4.53 resolve it, but is there any plan for it?

rudiv commented 1 year ago

This is a silly blocker, possibly on the part of Microsoft.Identity.Web for changing the API.

For anyone else that encounters this issue and if you're using Microsoft.Identity.Web, to save you some time you need to downgrade this package to version 2.10.0 to get the dependency down to 4.53.

onionhammer commented 1 year ago

I assume this is why I'm getting

Unhandled exception. System.MissingMethodException: Method not found: 'Microsoft.Identity.Client.ManagedIdentityApplicationBuilder Microsoft.Identity.Client.ManagedIdentityApplicationBuilder.Create(System.String)'. at Microsoft.Azure.StackExchangeRedis.CacheIdentityClient.CreateForUserAssignedManagedIdentity(String clientId) at Microsoft.Azure.StackExchangeRedis.AzureCacheOptionsProviderWithToken.GetIdentityClient(AzureCacheOptions azureCacheOptions) in C:__w\1\s\src\AzureCacheOptionsProviderWithToken.cs:line 84 at Microsoft.Azure.StackExchangeRedis.AzureCacheOptionsProviderWithToken..ctor(AzureCacheOptions azureCacheOptions) in C:__w\1\s\src\AzureCacheOptionsProviderWithToken.cs:line 43 at StackExchange.Redis.AzureCacheForRedis.ConfigureForAzureAsync(ConfigurationOptions configurationOptions, AzureCacheOptions azureCacheOptions) in C:__w\1\s\src\AzureCacheForRedis.cs:line 91 at StackExchange.Redis.AzureCacheForRedis.ConfigureForAzureWithUserAssignedManagedIdentityAsync(ConfigurationOptions configurationOptions, String clientId, String principalId) in C:__w\1\s\src\AzureCacheForRedis.cs:line 49

lsannicolas commented 1 year ago

Hello, we'll be adding support in a future version

onionhammer commented 1 year ago

@lsannicolas that was fast - support is already complete? Hmm, I don't see any PRs that mention this?

lsannicolas commented 1 year ago

We haven't created the PR yet. I'll reopen the issue and link the pr once that is posted

harika-g commented 1 year ago

When will the support for 4.55 version of Microsoft.Identity.Client be added?

lsannicolas commented 1 year ago

We’re hoping to add it in the next version release, but there’s no date set for that just yet. I can update here once we get a better idea of a timeline

bgavrilMS commented 1 year ago

@rudiv - I'm guessing you took a dependency on MSAL 4.53 for Managed Identity APIs? but the APIs were marked as experimental and we indeed changed them based on partner feedback

To everyone reading this, you can either downgrade the version Microsoft.Identity.Web, as suggested. Or you can directly reference Microsoft.Identity.Client 4.53.0

CC @gladjohn

philon-msft commented 1 year ago

The new release v2.0.0 uses the latest Microsoft.Identity.Client package. Please give it a try and let us know if you still see any issues.