Azure / Moneo

Distributed AI/HPC Monitoring Framework
MIT License
25 stars 16 forks source link

Fix the Geneva MDM endpoint settings #52

Closed PPPW closed 1 year ago

PPPW commented 1 year ago
  1. Fix a typo when checking if the Geneva MDM endpoint contains "prod"
  2. Set the "METRIC_ENDPOINT" env var to empty for prod so that the default endpoint will be used (refer to the following error message).

For # 2, when we try to start the Docker image with prod endpoint, the genevamdm says:

You passed in value: https://global.prod.microsoftmetrics.com/
The only supported values are https://global.int.microsoftmetrics.com/, https://az-int.metrics.nsatc.net/, https://az-int.int.microsoftmetrics.com/, https://global.ppe.microsoftmetrics.com/ and it should only be used for accessing int or ppe configuration environments.

If you've used any other option pointing to a specific stamp in the past, please remove it - it should work with default prod configuration environment.

As we tested, it worked fine if we use an empty string for prod.

RyoYang commented 1 year ago

Just curious, are you using Moneo for publishing metrics to your Prod Geneve account?

PPPW commented 1 year ago

Hi @RyoYang, thank you for reviewing the PR! We have a prod metrics account, but it's more like diagnostic prod, it's used for monitoring stress tests. We already made our own tool to publish metrics and logs to Geneva, before we discover Moneo, which is included in our HPC VM, so we decided to try it out. We'd be happy to discuss more about our use case and see if we can integrate our tool. Thanks!

RyoYang commented 1 year ago

Hi @RyoYang, thank you for reviewing the PR! We have a prod metrics account, but it's more like diagnostic prod, it's used for monitoring stress tests. We already made our own tool to publish metrics and logs to Geneva, before we discover Moneo, which is included in our HPC VM, so we decided to try it out. We'd be happy to discuss more about our use case and see if we can integrate our tool. Thanks!

Thank you for sharing your usage using Moneo with us, and we're glad to hear that your team is interested in it. If you encounter any issues, please don't hesitate to submit them to this repository or reach out to us directly. As for the discussion meeting, let's plan that offline.