Update Get-Install-Data az commands

Azure / Moodle

Tooling and guidance on deploying Scalable Moodle Clusters on Azure.

MIT License

153 stars 165 forks source link

Update Get-Install-Data az commands #264

Closed kaijohnson33 closed 2 years ago

kaijohnson33 commented 2 years ago

Switching to az deployment group as this is the warning otherwise: WARNING: This command is implicitly deprecated because command group 'group deployment' is deprecated and will be removed in a future release. Use 'deployment group' instead.

Also fix a few typos.

ghost commented 2 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: kaijohnson33 sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

SorraTheOrc commented 2 years ago

@kaijohnson33 thank you for your contribution. This is an important improvement to the docs. I'm sorry our over-zealous CLA bot has been triggered on this one. I've raised this internally to see if we can improve this behavior. Unfortunately, since the bot was triggered we cannot merge unless you are able to sign the CLA.

Again, sorry for the inconvenience, us humans are more appreciative than the bots :-D

kaijohnson33 commented 2 years ago

@kaijohnson33 thank you for your contribution. This is an important improvement to the docs. I'm sorry our over-zealous CLA bot has been triggered on this one. I've raised this internally to see if we can improve this behavior. Unfortunately, since the bot was triggered we cannot merge unless you are able to sign the CLA.

Again, sorry for the inconvenience, us humans are more appreciative than the bots :-D

Thanks Sorra, happy to help out. I just need to do the triple checking on my side I can sign it, so thanks for your patience for my first public github PR. Nice to join the 21st century but it's not always smooth :)