Closed BernieWhite closed 1 year ago
Initial batch of rules part of PR #1676
Remaining rules:
Thanks @jdewisscher for your progress so far on this issue. Do you think in the next few weeks (so we can target completion for v1.21.0) you would complete the remaining rules or should we plan to reassign this issue.
Hello,
I am not sure if its 100% related to this but since Monday I began to face the issues with Azure.Defender rule. Basicity I am getting Azure.Defender rule failed with message stating that I have pricingTier
set to 'Free'
. Based on this rule source code I understand that it is expecting to find 'standard'
but actually its already set to be 'standard'
. Please see a screenshot with few error messages examples.
Also I am attaching a module and a parameters so it would be easier to replicate the issue.
Any ideas why PSrule could see pricingTier as 'Free' instead of 'standard' while using attached module and parameter file?
@s1mb414 Thanks for reporting the issue. We will have a look at it.
Hello, @BernieWhite did you had a chance to look into this issue?
Hello, @BernieWhite did you had a chance to look into this issue?
@s1mb414 Thanks for the prompt. Sorry I lost track of this one. I've created a separate issue for tracking this bug. #1793
Unassigning @jdewisscher to allow someone else to pick this up.
This one should be fairly easy since it is already partially implemented for a number of cases. Use the existing cases defined here https://github.com/Azure/PSRule.Rules.Azure/blob/main/src/PSRule.Rules.Azure/rules/Azure.Defender.Rule.yaml as a guide.
Rule request
Any pricing plans deployed for Microsoft Defender for Cloud should use the
Standard
pricing tier.Let's create individual rules for each pricing plan to allow customers to granularly suppress as required.
Containers
VirtualMachines
SqlServers
AppServices
StorageAccounts
SqlServerVirtualMachines
KeyVaults
Dns
Arm
OpenSourceRelationalDatabases
CosmosDbs
For example: