feat(new): Added Azure.LogAnalytics.Replication

Azure / PSRule.Rules.Azure

Rules to validate Azure resources and infrastructure as code (IaC) using PSRule.

https://azure.github.io/PSRule.Rules.Azure/

MIT License

389 stars 84 forks source link

feat(new): Added Azure.LogAnalytics.Replication #2894

Closed BenjaminEngeset closed 3 months ago

BenjaminEngeset commented 3 months ago

PR Summary

Fixes #2893

Added Azure.LogAnalytics.Replication.

PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] Change is not breaking
[x] This PR is ready to merge and is not Work in Progress
Rule changes
- [x] Unit tests created/ updated
- [x] Rule documentation created/ updated
- [x] Link to a filed issue
- [x] Change log has been updated with change under unreleased section
Other code changes
- [ ] Unit tests created/ updated
- [ ] Link to a filed issue
- [ ] Change log has been updated with change under unreleased section

BenjaminEngeset commented 3 months ago

Hi @BernieWhite,

Could you please share your thoughts on this? Initially, I believed that Azure.Monitor.Workspace.Replication was the appropriate approach. However, upon further consideration, I am wondering if it would be better to separate each “sub-service.” Given the extensive nature of the Azure Monitor portfolio and its potential for further growth, this might provide better scalability and organization.

BernieWhite commented 3 months ago

Hi @BernieWhite,

Could you please share your thoughts on this? Initially, I believed that Azure.Monitor.Workspace.Replication was the appropriate approach. However, upon further consideration, I am wondering if it would be better to separate each “sub-service.” Given the extensive nature of the Azure Monitor portfolio and its potential for further growth, this might provide better scalability and organization.

I'm fine with this approach. Currently we group by resource.

BenjaminEngeset commented 3 months ago

Check the latest changes @BernieWhite. Should be all good to merge.