feat(new): Added Azure.Firewall.AvailabilityZones

Azure / PSRule.Rules.Azure

Rules to validate Azure resources and infrastructure as code (IaC) using PSRule.

https://azure.github.io/PSRule.Rules.Azure/

MIT License

389 stars 84 forks source link

feat(new): Added Azure.Firewall.AvailabilityZones #2915

Closed BenjaminEngeset closed 3 months ago

BenjaminEngeset commented 3 months ago

PR Summary

Fixes #2909

Added Azure.Firewall.AvailabilityZones.

PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] Change is not breaking
[x] This PR is ready to merge and is not Work in Progress
Rule changes
- [x] Unit tests created/ updated
- [x] Rule documentation created/ updated
- [x] Link to a filed issue
- [x] Change log has been updated with change under unreleased section
Other code changes
- [ ] Unit tests created/ updated
- [ ] Link to a filed issue
- [ ] Change log has been updated with change under unreleased section

BenjaminEngeset commented 3 months ago

Ready for review @BernieWhite.

BenjaminEngeset commented 3 months ago

Thanks for the great feedback, @BernieWhite! Both the static method and the functions you created earlier were very helpful in developing this rule.

I’ve made some updates based on your input. Could you take a look now and let me know your thoughts?

BenjaminEngeset commented 3 months ago

@BernieWhite,

We pushed at the same time and I pushed with force, saw the push notification from GitHub now.

Can you push it again?

BenjaminEngeset commented 3 months ago

@BenjaminEngeset thanks for the updates. I made a few tweaks and added a test case for a region without AZ support. If you are happy with the changes we should be good to merge.

Great work!

Looks good! Let's merge.