[RULE] Can "Associate a maintenance configuration" rule also belong to the Reliability pillar?

Azure / PSRule.Rules.Azure

Rules to validate Azure resources and infrastructure as code (IaC) using PSRule.

https://azure.github.io/PSRule.Rules.Azure/

MIT License

394 stars 85 forks source link

[RULE] Can "Associate a maintenance configuration" rule also belong to the Reliability pillar? #2925

Closed jeanchg closed 4 months ago

jeanchg commented 4 months ago

Existing rule

Azure.VM.MaintenanceConfig

Suggested rule

Can this rule also belong to the reliability pillar baseline? As per this VM recommendation in the "Reliability Hub", this is also considered a High Priority Reliability recommendation.

Pillar

Reliability

Additional context

For context, in AVM, to enforce Reliability recommendations through our CI, we leverage the Azure.Pillar.Reliability baseline, and we're currently missing this one.

BernieWhite commented 4 months ago

@jeanchg Technically we could but it's not something we do today. But there has been some movement in the WAF since this rule was created so it's probably best targeted to reliability instead of op ex anyway.

I propose we just move the rule to the reliability pillar, and also it's not a preview feature anymore so we can update the docs and remove the preview flag.

jeanchg commented 4 months ago

thanks @BernieWhite I wasn't sure having one rule in several pillars was something being done. Thanks for clarifying. Happy if it moves to reliability pillar and without the preview flag! Thank you.