Added Azure.VMSS.PublicIPAttached

Azure / PSRule.Rules.Azure

Rules to validate Azure resources and infrastructure as code (IaC) using PSRule.

https://azure.github.io/PSRule.Rules.Azure/

MIT License

394 stars 85 forks source link

Added Azure.VMSS.PublicIPAttached #3015

Closed BenjaminEngeset closed 2 months ago

BenjaminEngeset commented 2 months ago

PR Summary

Fixes #3014

Added Azure.VMSS.PublicIPAttached.

PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] Change is not breaking
[x] This PR is ready to merge and is not Work in Progress
Rule changes
- [x] Unit tests created/ updated
- [x] Rule documentation created/ updated
- [x] Link to a filed issue
- [x] Change log has been updated with change under unreleased section
Other code changes
- [ ] Unit tests created/ updated
- [ ] Link to a filed issue
- [ ] Change log has been updated with change under unreleased section

BenjaminEngeset commented 2 months ago

Ready for review, @BernieWhite.

This should address most scenarios.

I have not included the Microsoft.Compute/virtualMachineScaleSets/virtualMachines example, as it’s uncommon to configure an instance specifically. This scenario is likely relevant only for flexible orchestration, as the VMSS uniform configuration would typically override any instance-specific settings.

BenjaminEngeset commented 2 months ago

Requested changes have been implemented, @BernieWhite. Please check out my comment regarding your first suggestion.

I am happy with the rule now.

BenjaminEngeset commented 2 months ago

Thanks @BernieWhite. Based on this screenshot, could you please elaborate on this?