This repository includes a CI platform for and collection of mature and curated Bicep modules. The platform supports both ARM and Bicep and can be leveraged using GitHub actions as well as Azure DevOps pipelines.
The azureSecurityCenter module is not following CARML module design. It is not a resource type but more a construct of several resource types, hence it should be moved to the costructs folder.
Discuss if resources deployed by the module should have their own module and pipeline.
Microsoft.Security/autoProvisioningSettings
Microsoft.Security/deviceSecurityGroups
Microsoft.Security/iotSecuritySolutions
Microsoft.Security/pricings
Microsoft.Security/securityContacts
Microsoft.Security/workspaceSettings
The above are all deployed at subscription scope besides iotSecuritySolutions which have resource group scope. For this reason iotSecuritySolutions requires a nested module, which also does not comply with CARML design principles
Finally not all resources are tested through parameter files e.g. iotSecuritySolutions are not tested
Description
The azureSecurityCenter module is not following CARML module design. It is not a resource type but more a construct of several resource types, hence it should be moved to the costructs folder.
Discuss if resources deployed by the module should have their own module and pipeline.
The above are all deployed at subscription scope besides iotSecuritySolutions which have resource group scope. For this reason iotSecuritySolutions requires a nested module, which also does not comply with CARML design principles
Finally not all resources are tested through parameter files e.g. iotSecuritySolutions are not tested