Azure / ResourceModules

This repository includes a CI platform for and collection of mature and curated Bicep modules. The platform supports both ARM and Bicep and can be leveraged using GitHub actions as well as Azure DevOps pipelines.
https://aka.ms/carml
MIT License
724 stars 460 forks source link

[Feature Request]: Discuss restructuring azureSecurityCenter module #1524

Open eriqua opened 2 years ago

eriqua commented 2 years ago

Description

The azureSecurityCenter module is not following CARML module design. It is not a resource type but more a construct of several resource types, hence it should be moved to the costructs folder.

Discuss if resources deployed by the module should have their own module and pipeline.

The above are all deployed at subscription scope besides iotSecuritySolutions which have resource group scope. For this reason iotSecuritySolutions requires a nested module, which also does not comply with CARML design principles

Finally not all resources are tested through parameter files e.g. iotSecuritySolutions are not tested

rahalan commented 2 years ago

The team decides that this is a good idea.

eriqua commented 11 months ago

As per additional discussion, we should keep the module, but rename it as per current naming.