Azure / ResourceModules

This repository includes a CI platform for and collection of mature and curated Bicep modules. The platform supports both ARM and Bicep and can be leveraged using GitHub actions as well as Azure DevOps pipelines.
https://aka.ms/carml
MIT License
726 stars 457 forks source link

[PSRule] Integrate PSRule pre-flight checks with GH module validation workflows #2426

Closed eriqua closed 1 year ago

eriqua commented 1 year ago

Together with PSRule validation checks on PRs and on schedule on the whole repo, checks should also be integrated with each module validation pipeline.

This issue is about integrating checks with GH workflows, e.g., as a dedicated job running in parallel to the static validation and prior to the deployment validation.

A first implementation of this issue for, e.g., the KV module, is hosted by branch hack/topic6

eriqua commented 1 year ago

Suggestion: apply the needsfurtherdiscussion label.

OPT1: implement the additional check on all PRs as non blocking OPT2: implement the additional check on all PRs as blocking only after issue #2151 closure

AlexanderSehr commented 1 year ago

Question from #2453 : Should we move the ps-rule.yaml from root into utilities/pipelines/staticValidation.

@eriqua and myself discussed this already a little bit and the below notes are the short version:

We should figure out the pros and cons and then come to conclusion. While I personally would like to keep / (root) as clean/empty as possible, I understand that the effort/added code involved to implement this may outwheigh the benefits.

rahalan commented 1 year ago

Team decides to go for option 1 (audit mode). This decision will be revisited in the future.