Azure / ResourceModules

This repository includes a CI platform for and collection of mature and curated Bicep modules. The platform supports both ARM and Bicep and can be leveraged using GitHub actions as well as Azure DevOps pipelines.
https://aka.ms/carml
MIT License
726 stars 457 forks source link

[Feature Request] Test the usage of GitHub new feature for configuration variables in workflows (POC) #2553

Open ahmadabdalla opened 1 year ago

ahmadabdalla commented 1 year ago

Description

Context

From the documentation:

Previously, you needed to store this configuration data as encrypted secrets in order to reuse values in workflows. While extremely secure, this method did not allow for easy storage and retrieval of non-sensitive configuration data such as compiler flags, usernames, server names etc.

Configuration variables allows you to store your non sensitive data as plain text variables that can be reused across your workflows in your repository or organization. You can define variables at Organization, Repository or Environment level based on your requirement.

Link: https://github.blog/changelog/2023-01-10-github-actions-support-for-configuration-variables-in-workflows/

Requirement

rahalan commented 1 year ago

Let's discuss how to adopt it.

eriqua commented 1 year ago

I'd suggest leveraging the feature for the target private bicep registry (globally unique) name (currently stored in the settings.yml file)

AlexanderSehr commented 1 year ago

Following a discussion, we opted to use this feature. However, what will remain up to debate is what values we want to move to a variable. Suggestions are:

Note: Some variables may require a different handling for GitHub vs. ADO

AlexanderSehr commented 1 year ago

The idea is now to implement the suggestions / test the feature and then we can get to a final decision how many values we actually want to move around.

ahmadabdalla commented 1 year ago

Will work on a POC for this. Self-assigning.