search

Azure / ResourceModules

This repository includes a CI platform for and collection of mature and curated Bicep modules. The platform supports both ARM and Bicep and can be leveraged using GitHub actions as well as Azure DevOps pipelines.
https://aka.ms/carml
MIT License
724 stars 456 forks source link

[Bug Report]: Publicnetworkaccess #4543

Closed OussamaLarfaoui closed 6 months ago

OussamaLarfaoui commented 6 months ago

Describe the bug

I can't find the publicNetworkAccess parameter in the code at the path ResourceModules/modules/document-db/database-account/main.bicep.

In the old modules, the publicNetworkAccess parameter was present. This is crucial for us to disable public access and manage it via private endpoints.

To reproduce

After deployement you found that the network Access enabled for public

Code snippet

No response

Relevant log output

No response

AlexanderSehr commented 6 months ago

Hey @OussamaLarfaoui, the module has been ported to AVM a while back. You can find the latest version of the module here.

In it, you will find that you can set the publicNetworkAccess property via the networkRestrictions parameter :)

I'll close this issue for this repository. If the latest version in AVM does not work for you, please create an issue over there. The module's owner would then help you directly :)

OussamaLarfaoui commented 6 months ago

Thank you @AlexanderSehr !!