nnoaman
commented
2 months ago Hi Niaz,
Thank you for your contribution!
I wanted to clarify a small mistake on my part. While reviewing this pull request, I accidentally changed the base repository to an incorrect one. I've since corrected it by switching the base back to the correct repository (main).
Once you've agreed to the Contributor License Agreement and resolved the conflicts, everything should be in order for the review.
Apologies for any confusion this may have caused, and thanks again for your contribution!
NiazKhwaja
It can be seen on the last line that link is being populated with an extra "/" and another issue is that this particular package is no longer offered and there is an updated version. If MS can kindly update the entire packages to avoid manual intervention and keep SDAF automated as it should be.
TASK [roles-sap/0.1-bom-validator : BOM: S42021ISS00_v0001ms Download File SAPEXE_100-70006642.SAR] *** fatal: [localhost]: FAILED! => {"attempts": 1, "changed": false, "dest": "/home/azureadm/agent/_work/_temp/files/SAPEXE_100-70006642.SAR", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 401: Unauthorized", "status_code": 401, "url": "https://softwaredownloads.sap.com/file/0020000000254052023"}
TASK [roles-sap/0.1-bom-validator : BOM: Ensure URL is correct] **** ok: [localhost]
TASK [roles-sap/0.1-bom-validator : BOM: Ensure URL is correct] **** ok: [localhost] => { "msg": [ "file_url: 'https://softwaredownloads.sap.com//file/0020000000254052023" ] }
TASK [roles-sap/0.1-bom-validator : BOM: S42021ISS00_v0001ms Download File SAPEXE_100-70006642.SAR] *** fatal: [localhost]: FAILED! => {"changed": false, "dest": "/home/azureadm/agent/_work/_temp/files/SAPEXE_100-70006642.SAR", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 401: Unauthorized", "status_code": 401, "url": "https://softwaredownloads.sap.com//file/0020000000254052023"}