Azure / Synapse-workspace-deployment

MIT License
27 stars 36 forks source link

Managed Identity support added #15

Closed jhisc closed 3 years ago

jhisc commented 3 years ago

Added support for using managed identity authentication. Replacing the Service principal bearer call for the Metadata API service.

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

lordozb commented 3 years ago

Hello @jhisc Please don't make changes to index.js file. It is the compiled javascript file which is compiled using ncc compiler and is auto generated. You can make changes to utils/deploy_utils.ts and then use ncc to generate a new index.js file.

jhisc commented 3 years ago

Thank you @lordozb

I have updated the typescript files and recompiled using:

ncc build build_and_deploy/index.js

lordozb commented 3 years ago

Hello @jhisc Can you please resolve the conflicts and then we can go ahead and merge it. Thank you for contributing to Synapse workspace deployment.

jhisc commented 3 years ago

Thank you @lordozb I've resolved the conflicts and re-complied using the master branch

For future reference anyone else doing this:

cd build_and_deploy
npm install
npm run build

cd ../
ncc build build_and_deploy/index.js