DeleteArtifactsNotInTemplate - Orchestration Sequence Issue

[jeannejin]

Issue Description: current process sequence of section 'DeleteArtifactsNotInTemplate' in 'orchestrator.ts' file is ahead of deployment. Deployment fail in following scenario: Step 1: 'Pipline1' has an dataflow activity 'dataflow1', hence 'dataflow1' is calling from 'Pipeline1'. Initial deployment succeed Step 2: Updated 'Pipeline1' artifact by remove activity 'dataflow1'. Then delete dataflow 'dataflow1' since it is no longer needed Step 3: Deploy again, it fails, error message is

2022-05-12T17:33:14.9428660Z The document cannot be deleted since it is referenced by Pxxxxxxn. 2022-05-12T17:33:14.9433308Z Error during execution: Error: For Artifact: Bxxxxxxg deletion failed. {"status":"Failed","error":{"code":"DeleteDataFactoryResourceOrchestrationError","message":"The document cannot be deleted since it is referenced by Pxxxxxxn."}} 2022-05-12T17:33:14.9471695Z ##[error]Encountered with exception:Error: For Artifact: Bxxxxxxg deletion failed. {"status":"Failed","error":{"code":"DeleteDataFactoryResourceOrchestrationError","message":"The document cannot be deleted since it is referenced by Pxxxxxxn."}}

Work around: run deployment twice, first time with 'DeleteArtifactsNotInTemplate' set to 'false', and deploy again with 'DeleteArtifactsNotInTemplate' set to 'true'

Suggest Solution: In orchestrator.ts file, move 'DeleteArtifactsNotInTemplate' after deployment

[lordozb]

Hello @jeannejin The team will look into it and will come up with a fix.

[jeannejin]

Hi,

Thanks for the message. This is my first time to raise an issue in GitHub. I was wondering what is going to happen.

When it is fixed, would you please let me know? I will update my deployment pipeline to remove the walkaround. It double the deployment time now. 🙂

Thanks Jeanne

---

From: Aaditya Sharma @.> Sent: May 16, 2022 11:01 AM To: Azure/Synapse-workspace-deployment @.> Cc: jeannejin @.>; Mention @.> Subject: Re: [Azure/Synapse-workspace-deployment] DeleteArtifactsNotInTemplate - Orchestration Sequence Issue (Issue #56)

Hello @jeannejinhttps://github.com/jeannejin The team will look into it and will come up with a fix.

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/Synapse-workspace-deployment/issues/56#issuecomment-1127785253, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALRUT4ULRTSINA4EDW2QR6LVKJPMTANCNFSM5VZOYNOQ. You are receiving this because you were mentioned.Message ID: @.***>

[lordozb]

Hello @jeannejin Sure, I'll update it here.

Thanks.

[lordozb]

The fix has been released. Please use V1.6.0

[jeannejin]

Thanks Adaitya.On Tue, May 24, 2022 at 1:10 AM Aaditya Sharma @.***> wrote: Closed #56 as completed.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>