Azure / Synapse-workspace-deployment

MIT License
27 stars 34 forks source link

Update README on usage of validateDeploy #67

Closed vermegi closed 1 year ago

vermegi commented 1 year ago

The README isn't very clear on the exact usage of validateDeploy operations when you also want to replace parameters.

Full sample for this:

name: ValidateAndDeploy

on: workflow_dispatch

jobs: release: runs-on: ubuntu-latest steps:

Additionally, add to the README a sample on 2 step deploy, where validate is run first and then deploy:

name: ValidateAndDeploy2Steps

on: workflow_dispatch

jobs: release: runs-on: ubuntu-latest steps:

lordozb commented 1 year ago

Hello @vermegi

  1. Parameters file correspond to the parameters file generated by the Synapse workspace. OverrideArmParameters should always be used for over riding the parameters as mentioned in the READ ME - https://github.com/Azure/Synapse-workspace-deployment#overriding-parameters-overridearmparameters
  2. 'Validate' command is not supposed to be executed before 'deploy'. Deploy takes template and parameter files generated by the synapse workspace for the workspace publish branch. validate command generates template and parameter files from the collaboration branch.
  3. There is no need to specify ArtifactsFolder: '$GITHUB_WORKSPACE' as it is by default the location. You can directly access the folder.
vermegi commented 1 year ago

Then what about the way of working that is described here: https://techcommunity.microsoft.com/t5/azure-synapse-analytics-blog/automating-the-publishing-of-workspace-artifacts-in-synapse-cicd/ba-p/3603042 Thisvway of working does not always start from the collaboration/publish branch.