Azure / WALinuxAgent

Microsoft Azure Linux Guest Agent
http://azure.microsoft.com/
Apache License 2.0
538 stars 373 forks source link

[SUGGESTION] Consider renaming to "AzureGuestAgent" or similar #1765

Open macdice opened 4 years ago

macdice commented 4 years ago

Hi,

On a Linux system, it's a little strange to have a program called "Linux agent"; from the point of view of a Linux user, it's an Azure agent. On a FreeBSD or other type of open source Unix-family guest operating system, it doesn't make any sense whatsoever, and even the Microsoft FreeBSD-on-Azure documentation[1] refers to it as "Azure VM Guest Agent" in the text. Please consider renaming it. Thanks!

[1] https://docs.microsoft.com/en-us/azure/virtual-machines/linux/freebsd-intro-on-azure

narrieta commented 4 years ago

We can try, but what is it that we should rename? the service? thanks

macdice commented 4 years ago

Thanks for your reply. I think it'd be nice to rename at least the scripts/directories/egg, and eventually the repository. For example, here is what I see on a FreeBSD system that I installed on Azure with the Microsoft FreeBSD 12 image:

$ uname -a FreeBSD freebsd-D16s 12.1-RELEASE-p2 FreeBSD 12.1-RELEASE-p2 GENERIC amd64 $ ps aux | grep Linux root 1543 0.0 0.0 42872 22924 - S 06:03 0:00.78 python -u bin/WALinuxAgent-2.2.46-py2.7.egg -run-exthandlers (python2.7) tmunro 1579 0.0 0.0 4880 2400 0 R+ 06:04 0:00.00 grep Linux

There are also various other references like:

AGENT_DESCRIPTION = """ The Azure Linux Agent supports the provisioning and running of Linux VMs in the Azure cloud. This package should be installed on Linux disk images that are built to run in the Azure environment. """

That's in the same file that has explicit support for detecting at least FreeBSD and OpenBSD.

narrieta commented 4 years ago

I see. Sorry, those legacy names are embedded on way too many places (including documentation) to replace them. I could tweak the description to instead say "...installed on Linux/Unix disk images...".

"Azure VM Guest Agent" is used interchangeably for the Windows and Linux/Unix agent in different parts of the documentation.

macdice commented 4 years ago

Understood. Slipping "Linux/Unix" into a few places would be a good start, anyway, if that's something you can do. Thanks!