Azure / aca-landing-zone-accelerator

The Azure Container Apps landing zone accelerator is an open-source collection of architectural guidance and reference implementation to accelerate deployment of Azure Container Apps at scale.
https://aka.ms/aca-lza
MIT License
171 stars 81 forks source link

README.md is not up to date in the latest main version, leading to confusion? #124

Closed RustinAlexandruC closed 7 months ago

RustinAlexandruC commented 7 months ago

Hello,

In the latest main version, c49ea0f file scenarios/aca-internal/terraform/modules/01-hub/main.tf

there is no mention of the jumpbox in the main.tf file, while the README.md file mentions you will deploy a jumpbox (which is optional)

After executing these steps you'll have the hub resource group (rg-lzaaca-hub-dev-reg, by default) populated with a regional virtual network, Azure Bastion, and jump box virtual machines.

Resources Hub resource group Hub virtual network Azure Bastion (optional) Jump box virtual machine (optional)

Am I missing something here? Apologies for any mistake, beginner here.

thotheod commented 7 months ago

You are right, the documentation is kind of outdated there. The current implementation (documentation needs to be fixed) is deploying a Jumpbox in the spoke.

thotheod commented 7 months ago

fixed documentation