Azure / aca-landing-zone-accelerator

The Azure Container Apps landing zone accelerator is an open-source collection of architectural guidance and reference implementation to accelerate deployment of Azure Container Apps at scale.
https://aka.ms/aca-lza
MIT License
176 stars 90 forks source link

Feature/terraform implementation fix #60

Closed HoussemDellai closed 1 year ago

HoussemDellai commented 1 year ago

This branch is based on the terraform-implementation branch.

These changes were made: 1- Added dependency between Key vault secret and RBAC assignment 2- Fixed App Gateway config 3- Added VM script to install docker, azure cli and terraform: scenarios\shared\scripts\jumpbox-setup-cli-tools.sh 4- No need any more to deploy module 6 for App Gateway using JumpBox VM (opened external network access to Key vault) 5- Key vault still uses PE, but opened external firewall access to only the terraform machine: scenarios\shared\terraform\modules\keyvault\main.tf

Things to review again: 1- Used ifconfig.me to get terraform machine IP 2- The module 6 for Front Door is not yet reviewed