search

Azure / aca-landing-zone-accelerator

The Azure Container Apps landing zone accelerator is an open-source collection of architectural guidance and reference implementation to accelerate deployment of Azure Container Apps at scale.
https://aka.ms/aca-lza
MIT License
176 stars 90 forks source link

Givermei frontdoorfix #76

Closed vermegi closed 1 year ago

vermegi commented 1 year ago

This PR contains fixes for the Azure Front Door deployment.

  1. naming conventions didn't have a resourcename for frontDoor, which gave a failure for deploy.front-door.bicep file line 54
  2. changed AFD health probe to / as opposed to /health (preferable this value should be parameterized though)

Additional fixes that should be done (but not in this PR (yet?)).

I created the base setup with deployHelloWorldSample set to false I manually created a sampleapp (this was needed for fqdn input param for AFD)

I needed to also execute

az network vnet subnet update \ --name snet-pep \ --vnet-name myvnetname \ --resource-group myspokergname \ --disable-private-link-service-network-policies yes

for the private link service creation for AFD.

vermegi commented 1 year ago

And FYI for the az cli statement for he network policy, this can be added in the deploy.spoke.bicep file by adding after line 86:

privateLinkServiceNetworkPolicies: 'Disabled'

Not adding it to this PR as a commit though, since I'm not sure whether you would want this as part as the base deployment with app gw.