MSLearn Alignment: Bicep Implementation

thotheod commented 1 year ago

rationalized default network/subnets CIDRs
Jumpbox moved to spoke
subnet placeholders for Gateway and Firewall in Hub
Private DNS Zones in Hub
Add NSGs in every subnet in spoke network
Added assignment of Built in Container Apps related Azure policies - added some custom as well for demonstration
Added Diagnostics Settings where possible
added Zone Redundancy in resources that require it - give to choice to switch off to avoid errors in aread that do not support AZ
Application Gateway: Massive re-write
removed unnecessary keyvaultReader identity
Added DDoS to Gateway's public IP
rationalized bicep outputs
minor fixes
Diagram changes to reflect moficiations (subnet re-shuffling / DDoS etc)

NOTE: these changes are only for the Bicep implementation. Once finalized we will sync them with ARM implementation ("Deploy To Azure Button")

thotheod commented 1 year ago

NOTE: these changes are only for the Bicep implementation. Once finalized we will sync them with ARM implementation ("Deploy To Azure Button")

ckittel commented 1 year ago

Starting review now. Sorry for the delay, have been caught up in some other deliverables that kept me from this.

thotheod commented 1 year ago

did some fixes, accepted suggestions (thanks for those). Have a look please, and tell me if everything is OK now

Azure / aca-landing-zone-accelerator