Unable to set `ip-address` to `"Private"`

Azure / aci-deploy

Enable GitHub developers to deploy to Azure Container Instances using GitHub Actions

MIT License

63 stars 60 forks source link

Unable to set `ip-address` to `"Private"` #40

Closed mtbdeano closed 3 years ago

mtbdeano commented 3 years ago

Same error as https://github.com/Azure/aci-deploy/issues/17

https://github.com/Azure/aci-deploy/blob/10a287e023e486030363702cbfbca3ffd0b793ee/src/taskparameters.ts#L71

The above is obvs a bug the and condition is incorrect and makes it so that you are unable to set the ip address to Private because this is always only true for Public.

As a workaround, I'll have to stop using this ACI and manually create github action command line deploys using az container create

kanika1894 commented 3 years ago

Closing as it is duplicate of https://github.com/Azure/aci-deploy/issues/3