Fix some of the parameter validations for fields that require specific

Azure / aci-deploy

Enable GitHub developers to deploy to Azure Container Instances using GitHub Actions

MIT License

63 stars 60 forks source link

Fix some of the parameter validations for fields that require specific #43

Closed mauricioborges closed 3 years ago

ghost commented 3 years ago

All CLA requirements met.

mauricioborges commented 3 years ago

@mitsha-microsoft would you mind taking a look?

mitsha-microsoft commented 3 years ago

@mauricioborges LGTM, but I dont have permissions to close this PR. Tagging @anraghun @narula0781 who can close this PR

fkrafi commented 3 years ago

i have already created a PR for this issue, https://github.com/Azure/aci-deploy/pull/25 which has been hanging since Oct 31, 2020.

mauricioborges commented 3 years ago

It's true @fkrafi. Any chance we can have external contributors to this project? I'll be more than happy to start contributing as an admin to merge these PR. @mitsha-microsoft if you have any idea on how to do that, I would appreciate your help :)