search

Azure / aci-deploy

Enable GitHub developers to deploy to Azure Container Instances using GitHub Actions
MIT License
63 stars 60 forks source link

use secureValue for secure env variables #51

Closed el-pato closed 3 years ago

el-pato commented 3 years ago

ContainerInstanceManagementModels.EnvironmentVariable has a property secureValue which should be used for secure environment variables. The other property value is used for non-secure environment variables.

This should address #47

el-pato commented 3 years ago

@kanika1894 what do we need to do to get this reviewed?

kanika1894 commented 3 years ago

Thanks for your contribution @el-pato. Will look into it. @prein how does this PR look to you?

el-pato commented 3 years ago

I guess it will be good if we can do a slight update in action.yml. https://github.com/Azure/aci-deploy/blob/master/action.yml#L120 We can have something like key=secureValue. Feel free to update any relevant documentation regarding this.

IMO it'd be okay to leave the description as-is. You're still passing them in key=value format, it's just that the values are meant to be secure.

I'll add a small change to the readme to make the behavior of secure environment variables a little more clear.

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

el-pato commented 3 years ago

@kanika1894 updated the Readme. Look good?

prein commented 3 years ago

Sorry for late reply, LGTM, thanks @el-pato !