Support for private IPs, dns-name-label no longer required

Azure / aci-deploy

Enable GitHub developers to deploy to Azure Container Instances using GitHub Actions

MIT License

63 stars 60 forks source link

Support for private IPs, dns-name-label no longer required #69

Open davemaul opened 2 years ago

davemaul commented 2 years ago

Fixes #53

ghost commented 2 years ago

All CLA requirements met.

github-actions[bot] commented 2 years ago

This PR is idle because it has been open for 14 days with no activity.

davemaul commented 2 years ago

Push ;)

github-actions[bot] commented 2 years ago

This PR is idle because it has been open for 14 days with no activity.

davemaul commented 2 years ago

Push

github-actions[bot] commented 2 years ago

This PR is idle because it has been open for 14 days with no activity.

davemaul commented 2 years ago

Push

github-actions[bot] commented 2 years ago

This PR is idle because it has been open for 14 days with no activity.

SvenAelterman commented 2 years ago

Isn't using network profiles for virtual network integration deprecated now?

github-actions[bot] commented 2 years ago

This PR is idle because it has been open for 14 days with no activity.

artem-troitskiy commented 2 years ago

Would be great if this can be reviewed and, if everything looks fine, merged. This would save a lot of trouble at least for me :)

troyyyang commented 2 years ago

@BALAGA-GAYATRI any chance this will be reviewed?

github-actions[bot] commented 2 years ago

This PR is idle because it has been open for 14 days with no activity.

troyyyang commented 2 years ago

🥺 👉👈

davemaul commented 2 years ago

This is ridiculous 🤣

troyyyang commented 2 years ago

i tried using the azi cli action as a workaround, but then his this issue

https://github.com/Azure/azure-cli/issues/7593

BALAGA-GAYATRI commented 2 years ago

@davemaul sorry for the delayed response. In the last quarter, we haven't planned to make any investments on this action's enhancements. This PR shall be discussed and reviewed accordingly. I also want to understand about the testing process that was followed for committing to this change. Thanks :)

davemaul commented 2 years ago

I tested it with a project of ours. Nothing more to say. :D The change is minimal. However, it doesn't matter for us anymore because we dumped the usage of this action due to lack of maintenance. 😉

github-actions[bot] commented 2 years ago

This PR is idle because it has been open for 14 days with no activity.

mattGLB commented 1 year ago

Hello, when can we expect this update to be pushed?

AnguIar commented 7 months ago

@davemaul sorry for the delayed response. In the last quarter, we haven't planned to make any investments on this action's enhancements. This PR shall be discussed and reviewed accordingly. I also want to understand about the testing process that was followed for committing to this change. Thanks :)

Is there any update? This is a simple yet important feature for us.

stan-spotts commented 4 months ago

@davemaul sorry for the delayed response. In the last quarter, we haven't planned to make any investments on this action's enhancements. This PR shall be discussed and reviewed accordingly. I also want to understand about the testing process that was followed for committing to this change. Thanks :)

I don't understand such decisions. Microsoft has invested a ton in GitHub, and it's in their interest to ensure that actions that work with all of the resource types/services on Azure are working and current. And if this isn't the case, at least commit the time to review changes from the public and approve valid pull requests.

This is doing nothing but destroying the developer experience and belief that Microsoft supports the developer and devops community. I had to live through this as a blue badge in DPE when Microsoft abandoned ISV's in the 90's and spent years having to help gain back the trust. How can Microsoft not have learned from this?