search

Azure / aci-deploy

Enable GitHub developers to deploy to Azure Container Instances using GitHub Actions
MIT License
63 stars 60 forks source link

Removing JS from version control #71

Closed shubham1172 closed 2 years ago

shubham1172 commented 2 years ago

The source of truth for this repository is typescript code which is transpiled into JavaScript. Since we are storing both TS and JS code (which is derived from the former), it leads to issues like https://github.com/Azure/aci-deploy/pull/59

Question: why are we storing JS? Can we do without it?

shubham1172 commented 2 years ago

Also, the lib folder name does not sound right. It should be generated in a build folder instead.

AjayKaleMS commented 2 years ago

Hi @shubham1172 - We shall look into this enhancement request and keep you posted. Thanks

shubham1172 commented 2 years ago

@AjayKaleMS, thanks! Let me know if you have any thoughts, happy to send out a PR.

github-actions[bot] commented 2 years ago

This issue is idle because it has been open for 14 days with no activity.

BALAGA-GAYATRI commented 2 years ago

@shubham1172 We need either .js/ docker images/ shell script for the execution of action. Please refer this for the type of custom actions. So we need js files. And lib naming convention is followed for all the azure actions and changing it right way will be difficult. We shall definitely work on your suggestion for renaming this folder.

shubham1172 commented 2 years ago

Sure, that's fine - another way to temporarily mitigate this is to add a step in the repository's CI, that builds and verifies the lib directory. This ensures that there is no delta between the lib in source code and the lib generated from actual typescript files.