search

Azure / acr-builder

Azure Container Registry Build Runner
MIT License
38 stars 35 forks source link

Refactor secret management #420

Closed shahzzzam closed 1 year ago

shahzzzam commented 5 years ago

Is this a BUG REPORT or FEATURE REQUEST?: OPTIMIZATION

What happened?: Need to refactor Secret into OpaqueSecret, VaultSecret and MSISecret. Secret could be an interface that has ResolveChan and TimeoutChan, while other parameters like (ID, AKV, ArmResourceID) could come from VaultSecret/MSISecret.

What did you expect to happen?:

How do you reproduce it (as minimally and precisely as possible)?:

Environment:

Anything else we need to know?:

sajayantony commented 5 years ago

Should we close this or reprioritize? @northtyphoon

ehotinger commented 5 years ago

I think leave as-is, but not high prio