search

Azure / acr-builder

Azure Container Registry Build Runner
MIT License
38 stars 35 forks source link

Alias Work #468

Closed estebanreyl closed 5 years ago

estebanreyl commented 5 years ago

We have been discussing how to facilitate and improve on existing task yaml capabilities. In particular by looking at declaring aliases within the yaml files for reusability and general convenience. There's an ongoing high level discussion about this here: https://github.com/Azure/acr-builder/issues/464 . This draft implements the various proposed features although not all practices may be perfect (Golang and I are still only distant acquaintances).

I would appreciate some feedback on this work and will continue to improve upon it. As a note I have validated that everything here does run and properly works at least within the small testing framework I setup for this purpose at https://github.com/estebanreyl/preprocessor-test to enable use of the debugger and faster startup. Nonetheless everything should also work in this repo.

northtyphoon commented 5 years ago

I setup for this purpose at https://github.com/estebanreyl/preprocessor-test to enable use of the debugger and faster startup. Nonetheless everything should also work in this repo.

I assume you plan to migrate to the unit test here, right?

shahzzzam commented 5 years ago

@estebanreyl you can move PR from Draft to "Ready for review". Also, once you make changes - check the CI (acr-builder (Linux) & acr-builder (Windows)) to see why they fail.

northtyphoon commented 5 years ago

There are some lint errors in CI build.

https://dev.azure.com/azurecontainerregistry/acr-builder/_build/results?buildId=412

shahzzzam commented 5 years ago

Make sure to rebase your changes from upstream and resolve the CI errors.