search

Azure / acr-builder

Azure Container Registry Build Runner
MIT License
38 stars 35 forks source link

Getting context from a bad remote encoded URL prints improper error message #507

Closed shahzzzam closed 5 years ago

shahzzzam commented 5 years ago

Describe the bug A clear and concise description of what the bug is. Getting context from a bad remote encoded URL prints improper error message

To Reproduce Steps to reproduce the behavior: acb download . https://abc.blob.core.windows.net/a7fdb8ba2b604fc39fff7719c9c0443c-ep4eeithl2/source/201909120000/0f806a98-9168-4d71-a50b-101d30d0712f.tar.gz?sv=2018-03-28&sr=b&sig=G4KHMAO3wRxhrTILu6c5YC%2B0IYwKiJqbfqHCgTcS4wA%3D&se=2019-09-12T15%3A48%3A43Z&sp=cw

if the URL is expired, or errors out, then the error message printing has an issue.

unable to prepare context: unable to download remote context https://abc.blob.core.windows.net/a7fdb8ba2b604fc39fff7719c9c0443c-ep4eeithl2/source/201909120000/0f806a98-9168-4d71-a50b-101d30d07
12f.tar.gz?sv=2018-03-28&sr=b&sig=G4KHMAO3wRxhrTILu6c5YC%2B0IYwKiJqbfqHCgTcS4wA%3D&se=2019-09-12T15%3A48%3A43Z&sp=cw: failed to GET https://abc.blob.core.windows.net/a7fdb8ba2b604fc39fff7719c9
c0443c-ep4eeithl2/source/201909120000/0f806a98-9168-4d71-a50b-101d30d0712f.tar.gz?sv=2018-03-28&sr=b&sig=G4KHMAO3wRxhrTILu6c5YC[%!B(uint8=239) %!B(uint8=187) %!B(uint8=191) %!B(uint8=60) %!B(u
int8=63) %!B(uint8=120) %!B(uint8=109) %!B(uint8=108) %!B(uint8=32) %!B(uint8=118) %!B(uint8=101) %!B(uint8=114) %!B(uint8=115) %!B(uint8=105) %!B(uint8=111) %!B(uint8=110) %!B(uint8=61) %!B(u
int8=34) %!B(uint8=49) %!B(uint8=46) %!B(uint8=48) %!B(uint8=34) %!B(uint8=32) %!B(uint8=101) %!B(uint8=110) %!B(uint8=99) %!B(uint8=111) %!B(uint8=100) %!B(uint8=105) %!B(uint8=110) %!B(uint8
=103) %!B(uint8=61) %!B(uint8=34) %!B(uint8=117) %!B(uint8=116) %!B(uint8=102) %!B(uint8=45) %!B(uint8=56) %!B(uint8=34) %!B(uint8=63) %!B(uint8=62) %!B(uint8=60) %!B(uint8=69) %!B(uint8=114) 
%!B(uint8=114) %!B(uint8=111) %!B(uint8=114) %!B(uint8=62) %!B(uint8=60) %!B(uint8=67) %!B(uint8=111) %!B(uint8=100) %!B(uint8=101) %!B(uint8=62) %!B(uint8=65) %!B(uint8=117) %!B(uint8=116) %!
B(uint8=104) %!B(uint8=101) %!B(uint8=110) %!B(uint8=116) %!B(uint8=105) %!B(uint8=99) %!B(uint8=97) %!B(uint8=116) %!B(uint8=105) %!B(uint8=111) %!B(uint8=110) %!B(uint8=70) %!B(uint8=97) %!B
(uint8=105) %!B(uint8=108) %!B(uint8=101) %!B(uint8=100) %!B(uint8=60) %!B(uint8=47) %!B(uint8=67) %!B(uint8=111) %!B(uint8=100) %!B(uint8=101) %!B(uint8=62) %!B(uint8=60) %!B(uint8=77) %!B(ui
nt8=101) %!B(uint8=115) %!B(uint8=115) %!B(uint8=97) %!B(uint8=103) %!B(uint8=101) %!B(uint8=62) %!B(uint8=83) %!B(uint8=101) %!B(uint8=114) %!B(uint8=118) %!B(uint8=101) %!B(uint8=114) %!B(ui
nt8=32) %!B(uint8=102) %!B(uint8=97) %!B(uint8=105) %!B(uint8=108) %!B(uint8=101) %!B(uint8=100) %!B(uint8=32) %!B(uint8=116) %!B(uint8=111) %!B(uint8=32) %!B(uint8=97) %!B(uint8=117) %!B(uint
8=116) %!B(uint8=104) %!B(uint8=101) %!B(uint8=110) %!B(uint8=116) %!B(uint8=105) %!B(uint8=99) %!B(uint8=97) %!B(uint8=116) %!B(uint8=101) %!B(uint8=32) %!B(uint8=116) %!B(uint8=104) %!B(uint
8=101) %!B(uint8=32) %!B(uint8=114) %

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Any relevant environment information

Additional context Add any other context about the problem here.